Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-12 Thread Hannes Frederic Sowa
On 11.07.2016 16:48, David Miller wrote: > From: Bjørn Mork > Date: Mon, 11 Jul 2016 16:43:50 +0200 > >> The Juniper SSL VPN client use a "tun" interface and seems to >> be picky about visible changes.to it. Commit cc9da6cc4f56 >> ("ipv6: addrconf: use stable address generator for

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-12 Thread Bjørn Mork
Hannes, I just realized that I missed you on the CC list of the v2 patch. Sorry. It was definitely not my intention. I really appreciate the feedback you have kindly provided before. I guess you might have seen it in netdev anyway, but in case not, here is a direct patchwork link:

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-12 Thread Bjørn Mork
David Miller writes: > What really irks me is that we "fixing" something without knowing what > actually is the problem. Agreed > Someone needs to figure out exactly what is making the Juniper thing > unhappy. It really shouldn't care if a link local address is assigned >

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread David Miller
From: Bjørn Mork Date: Mon, 11 Jul 2016 16:43:50 +0200 > The Juniper SSL VPN client use a "tun" interface and seems to > be picky about visible changes.to it. Commit cc9da6cc4f56 > ("ipv6: addrconf: use stable address generator for ARPHRD_NONE") > made such interfaces get an

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Bjørn Mork
valdis.kletni...@vt.edu writes: > Tested against next-20160708, and the Juniper code works fine. Feel free > to stick a Tested-By: on the V2 patch... Thanks to both of you for verifying that it solves the Juniper problem. A tip: Patchworks is nice enough to automatically pick up tags from

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Valdis . Kletnieks
On Mon, 11 Jul 2016 16:43:50 +0200, Bjørn Mork said: > Link: https://bugzilla.kernel.org/show_bug.cgi?id=121131 > Fixes: cc9da6cc4f56 ("ipv6: addrconf: use stable address generator for ARPHRD _NONE") > Reported-by: Valdis Kletnieks > Reported-by: Jonas Lippuner

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Valdis . Kletnieks
On Mon, 11 Jul 2016 16:43:50 +0200, Bjørn Mork said: > And finally, Valdis and Jonas: could you please test this version too? It > works for me in my simulated setup, but I don't have the Juniper client > so I cannot verify that it actually solves the problem. The v1 patch worked. I'll be able

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Jonas Lippuner
Thanks Bjørn! I have applied the patch to v4.6.3 of linux-stable and Juniper VPN works with the patch. Please let me know if I should test the patch applied to any other code revision. Best, Jonas Original Message Subject: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN

[PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Bjørn Mork
The Juniper SSL VPN client use a "tun" interface and seems to be picky about visible changes.to it. Commit cc9da6cc4f56 ("ipv6: addrconf: use stable address generator for ARPHRD_NONE") made such interfaces get an auto-generated IPv6 link local address by default, similar to most other interface