Re: [PATCH v2 net] ixgbevf: fix invalid uses of napi_hash_del()

2016-12-03 Thread Jeff Kirsher
On Sat, 2016-12-03 at 07:00 -0800, Eric Dumazet wrote: > On Wed, 2016-11-16 at 07:26 -0800, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Calling napi_hash_del() before netif_napi_del() is dangerous > > if a synchronize_rcu() is not enforced before NAPI struct freeing.

Re: [PATCH v2 net] ixgbevf: fix invalid uses of napi_hash_del()

2016-12-03 Thread Eric Dumazet
On Wed, 2016-11-16 at 07:26 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Calling napi_hash_del() before netif_napi_del() is dangerous > if a synchronize_rcu() is not enforced before NAPI struct freeing. > > Lets leave this detail to core networking stack to get it

[PATCH v2 net] ixgbevf: fix invalid uses of napi_hash_del()

2016-11-16 Thread Eric Dumazet
From: Eric Dumazet Calling napi_hash_del() before netif_napi_del() is dangerous if a synchronize_rcu() is not enforced before NAPI struct freeing. Lets leave this detail to core networking stack to get it right. Signed-off-by: Eric Dumazet Cc: Jeff