Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

Hi, Sorry for digging up an old patch, but... ;-) dev_disable_lro() is a leftover from ancient times. If you read commit 27660515a, there is a hint where it should go. Please, read on if you'd like to fix this properly. 2015-11-03 3:55 GMT+01:00 Jarod Wilson : > There are some

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

On 11/03/2015 03:55 AM, Jarod Wilson wrote: [snip] > > +#define for_each_netdev_feature(mask_addr, feature) > \ > + int bit; > \ > + for_each_set_bit(bit, (unsigned long *)mask_addr,

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

On 11/03/2015 02:57 PM, Jarod Wilson wrote: > Geert Uytterhoeven wrote: >> On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov >> wrote: >>> On 11/03/2015 03:55 AM, Jarod Wilson wrote: >>> [snip] +#define for_each_netdev_feature(mask_addr, feature)

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

Nikolay Aleksandrov wrote: On 11/03/2015 02:57 PM, Jarod Wilson wrote: Geert Uytterhoeven wrote: On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov wrote: On 11/03/2015 03:55 AM, Jarod Wilson wrote: [snip] +#define for_each_netdev_feature(mask_addr, feature)

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov wrote: > On 11/03/2015 03:55 AM, Jarod Wilson wrote: > [snip] >> >> +#define for_each_netdev_feature(mask_addr, feature) >> \ >> + int bit;

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

Geert Uytterhoeven wrote: On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov wrote: On 11/03/2015 03:55 AM, Jarod Wilson wrote: [snip] +#define for_each_netdev_feature(mask_addr, feature) \ + int bit;

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

From: Jarod Wilson Date: Mon, 2 Nov 2015 21:55:59 -0500 > There are some netdev features, which when disabled on an upper device, > such as a bonding master or a bridge, must be disabled and cannot be > re-enabled on underlying devices. > > This is a rework of an earlier more

[PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

There are some netdev features, which when disabled on an upper device, such as a bonding master or a bridge, must be disabled and cannot be re-enabled on underlying devices. This is a rework of an earlier more heavy-handed appraoch, which simply disables and prevents re-enabling of netdev