Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-02 Thread Simon Horman
On Mon, Jun 01, 2015 at 02:56:25PM -0700, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 01 Jun 2015 07:12:37 -0700 Can we ensure offload_base contains a sensible order of expected types ? This seemed easy enough to kill, so I pushed the following into

[PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Toshiaki Makita
Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are currently not stripped by hardware. This patch adds GRO support for non-hardware-accelerated vlan and improves receive performance of

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Toshiaki Makita
On 15/06/01 (月) 23:12, Eric Dumazet wrote: On Mon, 2015-06-01 at 21:55 +0900, Toshiaki Makita wrote: @@ -668,6 +753,9 @@ static int __init vlan_proto_init(void) if (err 0) goto err5; + for (i = 0; i ARRAY_SIZE(vlan_packet_offloads); i++) +

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Eric Dumazet
On Tue, 2015-06-02 at 01:03 +0900, Toshiaki Makita wrote: I didn't have that concern because there are already other similar offloads (eth, mpls_uc, mpls_mc). But indeed, they and this could slow down GRO stack. Right, but these mpls offloads are not installed on my kernels ;) And I

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Eric Dumazet
On Mon, 2015-06-01 at 21:55 +0900, Toshiaki Makita wrote: @@ -668,6 +753,9 @@ static int __init vlan_proto_init(void) if (err 0) goto err5; + for (i = 0; i ARRAY_SIZE(vlan_packet_offloads); i++) + dev_add_offload(vlan_packet_offloads[i]); +

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 01 Jun 2015 07:12:37 -0700 Can we ensure offload_base contains a sensible order of expected types ? This seemed easy enough to kill, so I pushed the following into net-next: [PATCH] net: Add priority to packet_offload

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread David Miller
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Mon, 1 Jun 2015 21:55:06 +0900 Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are currently not stripped by hardware. This

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-01 Thread Toshiaki Makita
On 2015/06/02 8:51, David Miller wrote: From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Mon, 1 Jun 2015 21:55:06 +0900 Currently packets with non-hardware-accelerated vlan cannot be handled by GRO. This causes low performance for 802.1ad and stacked vlan, as their vlan tags are