Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-09 Thread Roman Gushchin
On Fri, Dec 08, 2017 at 03:39:43PM +, Quentin Monnet wrote: > 2017-12-08 14:12 UTC+ ~ Roman Gushchin > > On Fri, Dec 08, 2017 at 10:34:16AM +, Quentin Monnet wrote: > >> 2017-12-07 18:39 UTC+ ~ Roman Gushchin > >>> This patch adds basic cgroup bpf operations to bpftool: > >>> cgro

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Jakub Kicinski
On Fri, 8 Dec 2017 09:52:16 -0700, David Ahern wrote: > On 12/8/17 8:39 AM, Quentin Monnet wrote: > > I don't believe compatibility is an issue here, since the program and > > its documentation come together (so they should stay in sync) and are > > part of the kernel tree (so the tool should be co

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread David Ahern
On 12/8/17 8:39 AM, Quentin Monnet wrote: > I don't believe compatibility is an issue here, since the program and > its documentation come together (so they should stay in sync) and are > part of the kernel tree (so the tool should be compatible with the > kernel sources it comes with). My concern

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Quentin Monnet
2017-12-08 14:12 UTC+ ~ Roman Gushchin > On Fri, Dec 08, 2017 at 10:34:16AM +, Quentin Monnet wrote: >> 2017-12-07 18:39 UTC+ ~ Roman Gushchin >>> This patch adds basic cgroup bpf operations to bpftool: >>> cgroup list, attach and detach commands. >>> >>> Usage is described in the cor

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Roman Gushchin
On Fri, Dec 08, 2017 at 02:56:15PM +0100, Philippe Ombredanne wrote: > On Fri, Dec 8, 2017 at 11:34 AM, Quentin Monnet > wrote: > > 2017-12-07 18:39 UTC+ ~ Roman Gushchin > >> This patch adds basic cgroup bpf operations to bpftool: > >> cgroup list, attach and detach commands. > > [...] > >>

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Roman Gushchin
On Thu, Dec 07, 2017 at 02:23:06PM -0800, Jakub Kicinski wrote: > On Thu, 7 Dec 2017 18:39:09 +, Roman Gushchin wrote: > > This patch adds basic cgroup bpf operations to bpftool: > > cgroup list, attach and detach commands. > > > > Usage is described in the corresponding man pages, > > and exa

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Roman Gushchin
On Fri, Dec 08, 2017 at 10:34:16AM +, Quentin Monnet wrote: > 2017-12-07 18:39 UTC+ ~ Roman Gushchin > > This patch adds basic cgroup bpf operations to bpftool: > > cgroup list, attach and detach commands. > > > > Usage is described in the corresponding man pages, > > and examples are pro

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Philippe Ombredanne
On Fri, Dec 8, 2017 at 11:34 AM, Quentin Monnet wrote: > 2017-12-07 18:39 UTC+ ~ Roman Gushchin >> This patch adds basic cgroup bpf operations to bpftool: >> cgroup list, attach and detach commands. [...] >> --- /dev/null >> +++ b/tools/bpf/bpftool/cgroup.c >> @@ -0,0 +1,305 @@ >> +/* >> + *

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-08 Thread Quentin Monnet
2017-12-07 18:39 UTC+ ~ Roman Gushchin > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $ bpftool cgroup attach

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-07 Thread Philippe Ombredanne
Roman, On Thu, Dec 7, 2017 at 11:23 PM, Jakub Kicinski wrote: > On Thu, 7 Dec 2017 18:39:09 +, Roman Gushchin wrote: >> This patch adds basic cgroup bpf operations to bpftool: >> cgroup list, attach and detach commands. >> >> Usage is described in the corresponding man pages, >> and examples

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-07 Thread Jakub Kicinski
On Thu, 7 Dec 2017 18:39:09 +, Roman Gushchin wrote: > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $ bpftool

Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-07 Thread David Ahern
On 12/7/17 11:39 AM, Roman Gushchin wrote: > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $ bpftool cgroup attach

[PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations

2017-12-07 Thread Roman Gushchin
This patch adds basic cgroup bpf operations to bpftool: cgroup list, attach and detach commands. Usage is described in the corresponding man pages, and examples are provided. Syntax: $ bpftool cgroup list CGROUP $ bpftool cgroup attach CGROUP ATTACH_TYPE PROG [ATTACH_FLAGS] $ bpftool cgroup detac