Since char can be unsigned or signed, and bitwise operators may have
implementation-dependent results when performed on signed operands,
declare 'u8 *' operand instead.

Suggested-by: Davide Caratti <dcara...@redhat.com>
Signed-off-by: Roman Mashak <m...@mojatatu.com>
---
 net/sched/act_pedit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index caa6927a992c..ab151346d3d4 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -311,7 +311,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct 
tc_action *a,
                        }
 
                        if (tkey->offmask) {
-                               char *d, _d;
+                               u8 *d, _d;
 
                                if (!offset_valid(skb, hoffset + tkey->at)) {
                                        pr_info("tc action pedit 'at' offset %d 
out of bounds\n",
-- 
2.7.4

Reply via email to