Re: [PATCH v2 net 1/1] qede: Fix barrier usage after tx doorbell write.

2018-03-27 Thread David Miller
From: Manish Chopra Date: Tue, 27 Mar 2018 06:34:41 -0700 > Since commit c5ad119fb6c09b0297446be05bd66602fa564758 > ("net: sched: pfifo_fast use skb_array") driver is exposed > to an issue where it is hitting NULL skbs while handling TX > completions. Driver uses

[PATCH v2 net 1/1] qede: Fix barrier usage after tx doorbell write.

2018-03-27 Thread Manish Chopra
Since commit c5ad119fb6c09b0297446be05bd66602fa564758 ("net: sched: pfifo_fast use skb_array") driver is exposed to an issue where it is hitting NULL skbs while handling TX completions. Driver uses mmiowb() to flush the writes to the doorbell bar which is a write-combined bar, however on x86