Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

2016-02-17 Thread David Miller
From: Andrew Lunn Date: Tue, 16 Feb 2016 16:29:02 +0100 > On Mon, Feb 15, 2016 at 11:46:45PM +0100, Clemens Gruber wrote: >> For the Marvell 88E1510, marvell_of_reg_init was called too late, in the >> config_aneg function. >> Since commit 113c74d83eef ("net: phy: turn carrier off

Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

2016-02-16 Thread Florian Fainelli
On February 15, 2016 2:46:45 PM PST, Clemens Gruber wrote: >For the Marvell 88E1510, marvell_of_reg_init was called too late, in >the >config_aneg function. >Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), >this lead to the link not coming up

Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

2016-02-16 Thread Andrew Lunn
On Mon, Feb 15, 2016 at 11:46:45PM +0100, Clemens Gruber wrote: > For the Marvell 88E1510, marvell_of_reg_init was called too late, in the > config_aneg function. > Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), > this lead to the link not coming up at boot anymore, due to

[PATCH v3] phy: marvell: Fix and unify reg-init behavior

2016-02-15 Thread Clemens Gruber
For the Marvell 88E1510, marvell_of_reg_init was called too late, in the config_aneg function. Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"), this lead to the link not coming up at boot anymore, due to the phy state machine being stuck at waiting for interrupts (off by