Re: [PATCH v3 04/11] net: sched: always take reference to action

2018-05-28 Thread Marcelo Ricardo Leitner
On Mon, May 28, 2018 at 12:17:22AM +0300, Vlad Buslov wrote: > Without rtnl lock protection it is no longer safe to use pointer to tc > action without holding reference to it. (it can be destroyed concurrently) > > Remove unsafe action idr lookup function. Instead of it, implement safe tcf > idr

Re: [PATCH v3 04/11] net: sched: always take reference to action

2018-05-28 Thread Jiri Pirko
Sun, May 27, 2018 at 11:17:22PM CEST, vla...@mellanox.com wrote: >Without rtnl lock protection it is no longer safe to use pointer to tc >action without holding reference to it. (it can be destroyed concurrently) > >Remove unsafe action idr lookup function. Instead of it, implement safe tcf >idr

[PATCH v3 04/11] net: sched: always take reference to action

2018-05-27 Thread Vlad Buslov
Without rtnl lock protection it is no longer safe to use pointer to tc action without holding reference to it. (it can be destroyed concurrently) Remove unsafe action idr lookup function. Instead of it, implement safe tcf idr check function that atomically looks up action in idr and increments