Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Andrew Lunn
On Wed, Nov 15, 2017 at 04:19:56PM +0100, Marc Gonzalez wrote: > On 15/11/2017 16:03, Andrew Lunn wrote: > > > On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote: > > > >> On 15/11/2017 15:17, Andrew Lunn wrote: > >> > >> In our local branch, I have completely disabled flow control sup

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Måns Rullgård
Marc Gonzalez writes: > On 15/11/2017 16:03, Andrew Lunn wrote: > >> On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote: >> >>> On 15/11/2017 15:17, Andrew Lunn wrote: >>> >>> In our local branch, I have completely disabled flow control support, >>> so I don't have to worry about this

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Marc Gonzalez
On 15/11/2017 16:03, Andrew Lunn wrote: > On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote: > >> On 15/11/2017 15:17, Andrew Lunn wrote: >> >> In our local branch, I have completely disabled flow control support, >> so I don't have to worry about this problem. > > That is an interes

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Andrew Lunn
On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote: > On 15/11/2017 15:17, Andrew Lunn wrote: > > > nb8800_link_reconfigure() can be called whenever the link to the peer > > changes. auto-neg may happen later because the cable was not plugged > > in until later, etc. > > Hello Andrew,

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Marc Gonzalez
On 15/11/2017 15:17, Andrew Lunn wrote: > nb8800_link_reconfigure() can be called whenever the link to the peer > changes. auto-neg may happen later because the cable was not plugged > in until later, etc. Hello Andrew, AFAICS, Mans was right: trying to toggle the flow control bit when the RX DM

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Andrew Lunn
On Wed, Nov 15, 2017 at 11:53:23AM +0100, Marc Gonzalez wrote: > On 14/11/2017 14:22, Måns Rullgård wrote: > > > Marc Gonzalez wrote: > > > >> On 14/11/2017 13:38, Måns Rullgård wrote: > >> > >>> Marc Gonzalez writes: > >>> > The "flow control enable" bit can be tweaked, even if DMA is enabl

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-15 Thread Marc Gonzalez
On 14/11/2017 14:22, Måns Rullgård wrote: > Marc Gonzalez wrote: > >> On 14/11/2017 13:38, Måns Rullgård wrote: >> >>> Marc Gonzalez writes: >>> The "flow control enable" bit can be tweaked, even if DMA is enabled. >>> >>> No, it can't. Maybe on some of your newer chips it can, but not on t

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-14 Thread Måns Rullgård
Marc Gonzalez writes: > On 14/11/2017 13:38, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> The "flow control enable" bit can be tweaked, even if DMA is enabled. >> >> No, it can't. Maybe on some of your newer chips it can, but not on the >> older ones. > > Again, I suppose you are ref

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-14 Thread Marc Gonzalez
On 14/11/2017 13:38, Måns Rullgård wrote: > Marc Gonzalez writes: > >> The "flow control enable" bit can be tweaked, even if DMA is enabled. > > No, it can't. Maybe on some of your newer chips it can, but not on the > older ones. Again, I suppose you are referring to your SMP8642-based board.

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-14 Thread Måns Rullgård
Marc Gonzalez writes: > The "flow control enable" bit can be tweaked, even if DMA is enabled. No, it can't. Maybe on some of your newer chips it can, but not on the older ones. > Signed-off-by: Marc Gonzalez > --- > drivers/net/ethernet/aurora/nb8800.c | 18 +- > 1 file chang

[PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

2017-11-14 Thread Marc Gonzalez
The "flow control enable" bit can be tweaked, even if DMA is enabled. Signed-off-by: Marc Gonzalez --- drivers/net/ethernet/aurora/nb8800.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/n