Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-13 Thread Andrew Lunn
On Tue, Sep 13, 2016 at 03:34:17PM +0200, LABBE Corentin wrote: > On Fri, Sep 09, 2016 at 04:17:10PM +0200, Andrew Lunn wrote: > > > +Optional properties: > > > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. > > > Default is 0) > > > +- allwinner,rx-delay: RX clock

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-13 Thread LABBE Corentin
On Fri, Sep 09, 2016 at 04:17:10PM +0200, Andrew Lunn wrote: > > +Optional properties: > > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. > > Default is 0) > > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. > > Default is 0) > > What are the

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-12 Thread Andrew Lunn
> Hello > > Since the MDIO bus is a part of the sun8i-emac, does I really need > to create such a mdio node ? It is good practice. Part of the issue is that there are no written guidelines, so different drivers do different things. I'm trying to push all new drivers to have an MDIO node. >

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-12 Thread LABBE Corentin
On Fri, Sep 09, 2016 at 04:04:13PM +0200, Andrew Lunn wrote: > > +The device node referenced by "phy" or "phy-handle" should be a child node > > +of this node. See phy.txt for the generic PHY bindings. > > I've not looked at the code yet, but is this really true? Generally > there is not this

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-09 Thread Andrew Lunn
> +Optional properties: > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. > Default is 0) > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. > Default is 0) What are the units? pS? nS? Andrew

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-09 Thread Andrew Lunn
> +The device node referenced by "phy" or "phy-handle" should be a child node > +of this node. See phy.txt for the generic PHY bindings. I've not looked at the code yet, but is this really true? Generally there is not this limitation. You can point to any Ethernet phy anyway, so long as it is on

[PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-09 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Allwinner sun8i-emac driver. Signed-off-by: Corentin Labbe --- .../bindings/net/allwinner,sun8i-emac.txt | 64 ++ 1 file changed, 64 insertions(+) create mode 100644