Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

2017-11-14 Thread Andrew Lunn
On Tue, Nov 14, 2017 at 06:08:47PM +0100, Marc Gonzalez wrote: > On 14/11/2017 17:31, Andrew Lunn wrote: > > > On Tue, Nov 14, 2017 at 03:22:04PM +0100, Marc Gonzalez wrote: > > > >> On 14/11/2017 14:02, Måns Rullgård wrote: > >> > >>> Missing patch description. Don't bother though. I won't app

Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

2017-11-14 Thread Marc Gonzalez
On 14/11/2017 17:31, Andrew Lunn wrote: > On Tue, Nov 14, 2017 at 03:22:04PM +0100, Marc Gonzalez wrote: > >> On 14/11/2017 14:02, Måns Rullgård wrote: >> >>> Missing patch description. Don't bother though. I won't approve of >>> this implementation. >> >> I hope I can convince David that you s

Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

2017-11-14 Thread Andrew Lunn
On Tue, Nov 14, 2017 at 03:22:04PM +0100, Marc Gonzalez wrote: > On 14/11/2017 14:02, Måns Rullgård wrote: > > > Missing patch description. Don't bother though. I won't approve of > > this implementation. > > I hope I can convince David that you should not have veto power over > this driver jus

Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

2017-11-14 Thread Marc Gonzalez
On 14/11/2017 14:02, Måns Rullgård wrote: > Missing patch description. Don't bother though. I won't approve of > this implementation. I hope I can convince David that you should not have veto power over this driver just because it was you who submitted it upstream first. Per the copyright noti

Re: [PATCH v3 4/4] net: nb8800: Add support for suspend/resume

2017-11-14 Thread Måns Rullgård
Marc Gonzalez writes: > Signed-off-by: Marc Gonzalez Missing patch description. Don't bother though. I won't approve of this implementation. Suspend support has to depend on the chip since the EMAC core doesn't have anything of the kind. > --- > drivers/net/ethernet/aurora/nb8800.c | 22 ++

[PATCH v3 4/4] net: nb8800: Add support for suspend/resume

2017-11-14 Thread Marc Gonzalez
Signed-off-by: Marc Gonzalez --- drivers/net/ethernet/aurora/nb8800.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index b71d8fb80610..9af2423aed03 100644 --- a/drivers/net/ethernet/aurora/