Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-18 Thread Ka-Cheong Poon
On 07/19/2018 01:31 AM, David Miller wrote: From: Sowmini Varadhan Date: Wed, 18 Jul 2018 03:33:40 -0700 On (07/18/18 15:19), Ka-Cheong Poon wrote: bind() and connect() are using the sa_family/ss_family to have the application signal to the kernel about whether ipv4 or ipv6 is desired. (and

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-18 Thread Santosh Shilimkar
On 7/13/2018 4:02 AM, Ka-Cheong Poon wrote: This patch set adds IPv6 support to the kernel RDS and related modules. Existing RDS apps using IPv4 address continue to run without any problem. New RDS apps which want to use IPv6 address can do so by passing the address in struct sockaddr_in6 to

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-18 Thread David Miller
From: Sowmini Varadhan Date: Wed, 18 Jul 2018 03:33:40 -0700 > On (07/18/18 15:19), Ka-Cheong Poon wrote: >> >bind() and connect() are using the sa_family/ss_family to have >> >the application signal to the kernel about whether ipv4 or ipv6 is >> >desired. (and bind and connect are doing the

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-18 Thread Sowmini Varadhan
On (07/18/18 15:19), Ka-Cheong Poon wrote: > >bind() and connect() are using the sa_family/ss_family to have > >the application signal to the kernel about whether ipv4 or ipv6 is > >desired. (and bind and connect are doing the right thing for > >v4mapped, so that doesnt seem to be a problem there)

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-18 Thread Ka-Cheong Poon
On 07/17/2018 07:27 PM, Sowmini Varadhan wrote: On (07/17/18 13:32), Ka-Cheong Poon wrote: The app can use either structures to make the call. When the app fills in the structure, it knows what it is filling in, either sockaddr_in or sockaddr_in6. So it knows the right size to use. The app

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-17 Thread Sowmini Varadhan
On (07/17/18 13:32), Ka-Cheong Poon wrote: > > The app can use either structures to make the call. When the > app fills in the structure, it knows what it is filling in, > either sockaddr_in or sockaddr_in6. So it knows the right size > to use. The app can also use IPv4 mapped address in a

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-16 Thread Ka-Cheong Poon
On 07/17/2018 12:20 AM, Sowmini Varadhan wrote: - Looks like rds_connect() is checking things in the right order (thanks) However, rds_cancel_sent_to is still looking at the len to figure out the family.. as we move to ipv6, it would be better if we allow the caller to specify

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-16 Thread Sowmini Varadhan
- Looks like rds_connect() is checking things in the right order (thanks) However, rds_cancel_sent_to is still looking at the len to figure out the family.. as we move to ipv6, it would be better if we allow the caller to specify struct sockaddr_storage, or even a union of

[PATCH v3 net-next 0/3] rds: IPv6 support

2018-07-13 Thread Ka-Cheong Poon
This patch set adds IPv6 support to the kernel RDS and related modules. Existing RDS apps using IPv4 address continue to run without any problem. New RDS apps which want to use IPv6 address can do so by passing the address in struct sockaddr_in6 to bind(), connect() or sendmsg(). And those apps