Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-25 Thread Simon Horman
On Fri, Sep 21, 2018 at 03:01:44PM +0200, Andrew Lunn wrote: > > Thanks Andrew, > > > > it seems that removing Aysm Pause does the trick. > > Great. > > I will submit the patch today. > > I see two possible followups: > > 1) Figure out why auto-neg does not complete when Pause is >

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-21 Thread Andrew Lunn
> Thanks Andrew, > > it seems that removing Aysm Pause does the trick. Great. I will submit the patch today. I see two possible followups: 1) Figure out why auto-neg does not complete when Pause is advertised. Is this a problem with the local PHY or the link partner? The Micrel we have some

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-21 Thread Simon Horman
On Thu, Sep 20, 2018 at 03:25:30PM +0200, Andrew Lunn wrote: > > 1. net-next: cf7d97e1e54d ("net: mdio: remove duplicated include from > > mdio_bus.c") > > > > # mii-tool -vv eth0 > > Using SIOCGMIIPHY=0x8947 > > eth0: no link > > registers for MII PHY 0: > > 1140 7949 0022 1622 0d81 c1e1

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-20 Thread Andrew Lunn
> 1. net-next: cf7d97e1e54d ("net: mdio: remove duplicated include from > mdio_bus.c") > > # mii-tool -vv eth0 > Using SIOCGMIIPHY=0x8947 > eth0: no link > registers for MII PHY 0: > 1140 7949 0022 1622 0d81 c1e1 000f > 0300 3000 >

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-18 Thread Andrew Lunn
> Hi Andrew, Hi Simon Thanks for the dumps > 1. net-next: cf7d97e1e54d ("net: mdio: remove duplicated include from > mdio_bus.c") > > basic status: no link > capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD > 10baseT-FD 10baseT-HD > advertising: 100baseTx-FD

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-18 Thread Simon Horman
On Mon, Sep 17, 2018 at 05:38:11PM +0200, Andrew Lunn wrote: > On Mon, Sep 17, 2018 at 05:13:07PM +0200, Simon Horman wrote: > > On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote: > > > Some MAC hardware cannot support a subset of link modes. e.g. often > > > 1Gbps Full duplex is

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-17 Thread Andrew Lunn
On Mon, Sep 17, 2018 at 05:13:07PM +0200, Simon Horman wrote: > On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote: > > Some MAC hardware cannot support a subset of link modes. e.g. often > > 1Gbps Full duplex is supported, but Half duplex is not. Add a helper > > to remove such a link

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-17 Thread Simon Horman
On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote: > Some MAC hardware cannot support a subset of link modes. e.g. often > 1Gbps Full duplex is supported, but Half duplex is not. Add a helper > to remove such a link mode. > > Signed-off-by: Andrew Lunn > Reviewed-by: Florian Fainelli

[PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-11 Thread Andrew Lunn
Some MAC hardware cannot support a subset of link modes. e.g. often 1Gbps Full duplex is supported, but Half duplex is not. Add a helper to remove such a link mode. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 6 +++---