Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

2017-04-25 Thread Doug Ledford
On Mon, 2017-04-24 at 18:46 +0300, Yuval Shaia wrote: > On Tue, Mar 14, 2017 at 07:58:43PM +0200, Leon Romanovsky wrote: > > > > On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > > > > > > This logic seems to be duplicated in (at least) three separate > > > files. > > > Move it to on

Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

2017-04-24 Thread Yuval Shaia
On Tue, Mar 14, 2017 at 07:58:43PM +0200, Leon Romanovsky wrote: > On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-off-by: Yuval Shaia > > --- > > v

Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

2017-03-14 Thread Leon Romanovsky
On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > This logic seems to be duplicated in (at least) three separate files. > Move it to one place so code can be re-use. > > Signed-off-by: Yuval Shaia > --- > v0 -> v1: > * Add missing #include > * Rename to genaddrconf_ifid_eu

[PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

2017-03-14 Thread Yuval Shaia
This logic seems to be duplicated in (at least) three separate files. Move it to one place so code can be re-use. Signed-off-by: Yuval Shaia --- v0 -> v1: * Add missing #include * Rename to genaddrconf_ifid_eui48 v1 -> v2: * Reset eui[0] to default if dev_id is used v2 ->