Re: [PATCH v4] rfkill: Add rfkill-any LED trigger

2017-01-09 Thread Johannes Berg
> > Looks better, but > > > > > +static struct work_struct rfkill_any_work; > > > > At least on module exit you need to cancel this work. > > It is cancelled in rfkill_any_led_trigger_unregister().  It seemed > fitting to do it this way as rfkill_any_work is initialized in > rfkill_any_led_trig

Re: [PATCH v4] rfkill: Add rfkill-any LED trigger

2017-01-06 Thread Michał Kępień
> On Fri, 2017-01-06 at 07:07 +0100, Michał Kępień wrote: > > Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill- > > any, > > which may be useful on laptops with a single "radio LED" and multiple > > radio transmitters.  The trigger is meant to turn a LED on whenever > > there is

Re: [PATCH v4] rfkill: Add rfkill-any LED trigger

2017-01-06 Thread Johannes Berg
On Fri, 2017-01-06 at 07:07 +0100, Michał Kępień wrote: > Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill- > any, > which may be useful on laptops with a single "radio LED" and multiple > radio transmitters.  The trigger is meant to turn a LED on whenever > there is at least one

[PATCH v4] rfkill: Add rfkill-any LED trigger

2017-01-05 Thread Michał Kępień
Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill-any, which may be useful on laptops with a single "radio LED" and multiple radio transmitters. The trigger is meant to turn a LED on whenever there is at least one radio transmitter active and turn it off otherwise. Signed-off-by