From: Julien Grall julien.gr...@citrix.com
Date: Tue, 16 Jun 2015 20:10:48 +0100
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by:
On 16.06.15 at 21:10, julien.gr...@citrix.com wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
To save on the space taken by the format strings you should prefer
%#x over 0x%x (like we do in the hypervisor).
Jan
--
To unsubscribe from
On Wed, 2015-06-17 at 10:30 +0100, Julien Grall wrote:
I see different opinion on whether using 0x% or %#. As I plan to resend
a version with the commit message update, shall I use %#?
I think it's mostly pointless bike-shedding over a saving measured in
single digit bytes, use whichever you
Hi Ian,
On 17/06/2015 10:25, Ian Campbell wrote:
On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with
On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall
On Tue, 2015-06-16 at 16:55 -0700, Joe Perches wrote:
0x%x is easier and simpler to visualize than %#x.
They also don't produce the same output if the value is 0 (0x%x=0x0, %
#x=0), which can matter if you are trying to line up a column or
whatever.
Ian.
--
To unsubscribe from this list: send
On Tue, 2015-06-16 at 23:07 +0300, Sergei Shtylyov wrote:
On 06/16/2015 10:10 PM, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
xenvif_queue
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell
Hello.
On 06/16/2015 10:10 PM, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall
Hello.
On 06/17/2015 01:09 AM, Joe Perches wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
xenvif_queue *queue,
if
On Wed, 2015-06-17 at 01:29 +0300, Sergei Shtylyov wrote:
Hello.
On 06/17/2015 01:09 AM, Joe Perches wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
11 matches
Mail list logo
