RE: [PATCH v4 5/7] thunderbolt: Networking state machine

2016-07-27 Thread Levy, Amir (Jer)
On Mon, Jul 25 2016, 01:36 AM, Lukas Wunner wrote: > On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote: > > + const unique_id_be proto_uuid = > APPLE_THUNDERBOLT_IP_PROTOCOL_UUID; > > + > > + if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid, > > + sizeof(proto_uuid)) !=

Re: [PATCH v4 5/7] thunderbolt: Networking state machine

2016-07-24 Thread Lukas Wunner
On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote: > + const unique_id_be proto_uuid = APPLE_THUNDERBOLT_IP_PROTOCOL_UUID; > + > + if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid, > +sizeof(proto_uuid)) != 0) { You may want to use the uuid_be data type provided

[PATCH v4 5/7] thunderbolt: Networking state machine

2016-07-18 Thread Amir Levy
Negotiation states that a peer goes through in order to establish the communication with the second peer. This includes communication with upper layer and additional infrastructure support to communicate with the second peer through ICM. Signed-off-by: Amir Levy ---