Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Tom Herbert
On Thu, May 28, 2015 at 2:44 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote: @@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = { }, { .key_id =

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Eric Dumazet
On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote: @@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = { }, { .key_id = FLOW_DISSECTOR_KEY_IPV4_ADDRS, - .offset = offsetof(struct flow_keys, addrs), +

[PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-28 Thread Tom Herbert
This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:40AM CEST, t...@herbertland.com wrote: This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-22 Thread Tom Herbert
On Fri, May 22, 2015 at 12:57 AM, Jiri Pirko j...@resnulli.us wrote: Fri, May 22, 2015 at 02:11:40AM CEST, t...@herbertland.com wrote: This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in

[PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-21 Thread Tom Herbert
This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-21 Thread Cong Wang
On Thu, May 21, 2015 at 5:11 PM, Tom Herbert t...@herbertland.com wrote: static inline void ip6_set_txhash(struct sock *sk) { @@ -700,8 +714,11 @@ static inline void ip6_set_txhash(struct sock *sk) memset(keys, 0, sizeof(keys)); - keys.addrs.src = (__force