Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-12 07:20 PM, Eric Dumazet wrote: On Mon, 2016-09-12 at 16:10 -0700, Eric Dumazet wrote: diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c index 508e051304fb62627e61b5065b2325edd1b84f2e..dc9dd8ae7d5405f76c775278dac7689655b21041 100644 --- a/net/core/gen_stats.c +++

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-12 07:02 PM, Jamal Hadi Salim wrote: Looks like typical starvation caused by aggressive softirq. Well, then it is strange that in one case a tc dump of the rule was immediate and in the other case it was consistent for 5-15 seconds. I may be going nuts because i cant reproduce

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On Mon, 2016-09-12 at 16:10 -0700, Eric Dumazet wrote: > > diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c > index > 508e051304fb62627e61b5065b2325edd1b84f2e..dc9dd8ae7d5405f76c775278dac7689655b21041 > 100644 > --- a/net/core/gen_stats.c > +++ b/net/core/gen_stats.c > @@ -142,10

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On Mon, 2016-09-12 at 19:02 -0400, Jamal Hadi Salim wrote: > On 16-09-12 06:26 PM, Eric Dumazet wrote: > > On Mon, 2016-09-12 at 18:14 -0400, Jamal Hadi Salim wrote: > > > >> I noticed some very weird issues when I took that out. > >> Running sufficiently large amount of traffic (ping -f is

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-12 06:26 PM, Eric Dumazet wrote: On Mon, 2016-09-12 at 18:14 -0400, Jamal Hadi Salim wrote: I noticed some very weird issues when I took that out. Running sufficiently large amount of traffic (ping -f is sufficient) I saw that when i did a dump it took anywhere between 6-15 seconds.

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On Mon, 2016-09-12 at 18:14 -0400, Jamal Hadi Salim wrote: > I noticed some very weird issues when I took that out. > Running sufficiently large amount of traffic (ping -f is sufficient) > I saw that when i did a dump it took anywhere between 6-15 seconds. > With the read_lock in place response

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-12 06:01 PM, Eric Dumazet wrote: On Mon, 2016-09-12 at 16:46 -0400, Jamal Hadi Salim wrote: + +static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a, + int bind, int ref) +{ + struct tcf_skbmod *d = to_skbmod(a); + unsigned char *b =

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-12 05:58 PM, Eric Dumazet wrote: On Mon, 2016-09-12 at 16:46 -0400, Jamal Hadi Salim wrote: From: Jamal Hadi Salim + + /* XXX: if you are going to edit more fields beyond ethernet header +* (example when you add IP header replacement or vlan swap) +

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On Mon, 2016-09-12 at 16:46 -0400, Jamal Hadi Salim wrote: > + > +static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a, > +int bind, int ref) > +{ > + struct tcf_skbmod *d = to_skbmod(a); > + unsigned char *b = skb_tail_pointer(skb); > + struct

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On Mon, 2016-09-12 at 16:46 -0400, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > + > + /* XXX: if you are going to edit more fields beyond ethernet header > + * (example when you add IP header replacement or vlan swap) > + * then MAX_EDIT_LEN needs to change

[PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this: sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \ u32 match ip protocol 1 0xff flowid 1:2 \ action pedit

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

Hi Jamal, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jamal-Hadi-Salim/net_sched-Introduce-skbmod-action/20160907-095338 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

From: Jamal Hadi Salim Date: Tue, 6 Sep 2016 09:54:28 -0400 > On 16-09-06 09:37 AM, Jamal Hadi Salim wrote: >> From: Jamal Hadi Salim >> >> This action is intended to be an upgrade from a usability perspective >> from pedit (as well as operational

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On Tue, 2016-09-06 at 09:37 -0400, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > + > +struct tcf_skbmod_params { > + struct rcu_head rcu; > + u64 flags; /*up to 64 types of operations; extend if needed */ > + u8 eth_dst[ETH_ALEN]; > + u16

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

On 16-09-06 09:37 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this: Dave, I will have to send some new version of this action - so please

[PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this: sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \ u32 match ip protocol 1 0xff flowid 1:2 \ action pedit