Re: [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

Hi, One minor comment: The return type of xge_init_hw() should be changed to be void, as the method xge_port_reset() always returns 0; and also the return type of xge_port_reset() should be changed to be void, it never fails; see in [PATCH v4 net-next 3/6] drivers: net: xgene-v2: Add ethernet

Re: [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

On 03/07/2017 05:08 PM, Iyappan Subramanian wrote: > This patch adds, > > - probe, remove, shutdown > - open, close and stats > - create and delete ring > - request and delete irq > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Keyur Chudgar

[PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

This patch adds, - probe, remove, shutdown - open, close and stats - create and delete ring - request and delete irq Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/main.c | 510