RE: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-18 Thread Appana Durga Kedareswara Rao
Hi Andrew, Thanks for the review... > > > +static int xgmiitorgmii_read_status(struct phy_device *phydev) { > > + struct gmii2rgmii *priv = phydev->priv; > > + u16 val = 0; > > + > > + priv->phy_drv->read_status(phydev); > > This can return an error, in which case phydev->speed

Re: [PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-16 Thread Andrew Lunn
> +static int xgmiitorgmii_read_status(struct phy_device *phydev) > +{ > + struct gmii2rgmii *priv = phydev->priv; > + u16 val = 0; > + > + priv->phy_drv->read_status(phydev); This can return an error, in which case phydev->speed should not be trusted. I've not thought locking all

[PATCH v6 3/3] net: phy: Add gmiitorgmii converter support

2016-08-10 Thread Kedareswara rao Appana
This patch adds support for gmiitorgmii converter. The GMII to RGMII IP core provides the Reduced Gigabit Media Independent Interface (RGMII) between Ethernet physical media Devices and the Gigabit Ethernet controller. This core can Switch dynamically between the three different speed modes of