Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-28 Thread Andrew Lunn
On Wed, Jun 27, 2018 at 10:54:28AM -0700, Paul Burton wrote: > Hi Andrew, > > On Wed, Jun 27, 2018 at 07:30:14PM +0200, Andrew Lunn wrote: > > On Tue, Jun 26, 2018 at 05:06:07PM -0700, Paul Burton wrote: > > > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > > > the case,

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Paul Burton
Hi Florian, On Wed, Jun 27, 2018 at 10:54:24AM -0700, Florian Fainelli wrote: > On 06/26/2018 05:06 PM, Paul Burton wrote: > > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > > including both the

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Paul Burton
Hi Andrew, On Wed, Jun 27, 2018 at 07:30:14PM +0200, Andrew Lunn wrote: > On Tue, Jun 26, 2018 at 05:06:07PM -0700, Paul Burton wrote: > > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > >

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Florian Fainelli
On 06/26/2018 05:06 PM, Paul Burton wrote: > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > including both the AR8031 used by the Minnowboard & the RTL8211E used by > the MIPS Boston development

Re: [PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-27 Thread Andrew Lunn
On Tue, Jun 26, 2018 at 05:06:07PM -0700, Paul Burton wrote: > When using a PHY connected via RGMII, as the pch_gbe driver presumes is > the case, the RX clock is provided by the PHY to the MAC. Various PHYs, > including both the AR8031 used by the Minnowboard & the RTL8211E used by > the MIPS

[PATCH v7 06/11] net: pch_gbe: Only enable MAC when PHY link is active

2018-06-26 Thread Paul Burton
When using a PHY connected via RGMII, as the pch_gbe driver presumes is the case, the RX clock is provided by the PHY to the MAC. Various PHYs, including both the AR8031 used by the Minnowboard & the RTL8211E used by the MIPS Boston development board, will stop generating the RX clock when the