Re: [PATCH v7 09/11] net: pch_gbe: Convert to mdiobus and phylib

2018-06-28 Thread Andrew Lunn
> Would you prefer that the MAC driver instead selects the PHY drivers for > all PHYs known to have been used with the MAC? Or would you be happy if > I added the equivalent in patch 11: Hi Paul Generally, you don't list any specific PHY. All distribution kernels simply enable all PHYs as kernel

Re: [PATCH v7 09/11] net: pch_gbe: Convert to mdiobus and phylib

2018-06-27 Thread Paul Burton
Hi Andrew, On Wed, Jun 27, 2018 at 07:51:44PM +0200, Andrew Lunn wrote: > > @@ -5,7 +5,8 @@ > > config PCH_GBE > > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" > > depends on PCI && (X86_32 || COMPILE_TEST) > > - select MII > > + select PHYLIB > > + imply AT803X_PHY if

Re: [PATCH v7 09/11] net: pch_gbe: Convert to mdiobus and phylib

2018-06-27 Thread Andrew Lunn
> @@ -5,7 +5,8 @@ > config PCH_GBE > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" > depends on PCI && (X86_32 || COMPILE_TEST) > - select MII > + select PHYLIB > + imply AT803X_PHY if X86_32 > select PTP_1588_CLOCK_PCH > select NET_PTP_CLASSIFY That is

[PATCH v7 09/11] net: pch_gbe: Convert to mdiobus and phylib

2018-06-26 Thread Paul Burton
From: Andrew Lunn Convert this driver to use the mdio bus and phylib infrastructure. It will then use the common AT803X PHY driver, rather than use its own code. Have the shared code also handle the GPIO used to reset the PHY. Over all, these changes should make it easier to use other PHYs with