Re: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb()

2018-03-29 Thread Sinan Kaya
Hi Ariel, On 3/29/2018 5:17 AM, Elior, Ariel wrote: >> Subject: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb() >> >> barrier() doesn't guarantee memory writes to be observed by the hardware on >> all architectures. barrier() only tells compiler not to m

RE: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb()

2018-03-29 Thread Elior, Ariel
> Subject: [PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb() > > barrier() doesn't guarantee memory writes to be observed by the hardware on > all architectures. barrier() only tells compiler not to move this code > with respect to other read/writes. > > I

[PATCH v7 3/7] bnx2x: Replace doorbell barrier() with wmb()

2018-03-25 Thread Sinan Kaya
barrier() doesn't guarantee memory writes to be observed by the hardware on all architectures. barrier() only tells compiler not to move this code with respect to other read/writes. If memory write needs to be observed by the HW, wmb() is the right choice. Signed-off-by: Sinan Kaya --- drivers/