Re: [PATCHv2] net/xfrm: Revert "[XFRM]: Do not add a state whose SPI is zero to the SPI hash."

2018-05-06 Thread Steffen Klassert
On Fri, May 04, 2018 at 02:20:09AM +0100, Dmitry Safonov wrote: > This reverts commit 7b4dc3600e48 ("[XFRM]: Do not add a state whose SPI > is zero to the SPI hash."). > > Zero SPI is legal and defined for IPcomp. > We shouldn't omit adding the state to SPI hash because it'll not be > possible to

[PATCHv2] net/xfrm: Revert "[XFRM]: Do not add a state whose SPI is zero to the SPI hash."

2018-05-03 Thread Dmitry Safonov
This reverts commit 7b4dc3600e48 ("[XFRM]: Do not add a state whose SPI is zero to the SPI hash."). Zero SPI is legal and defined for IPcomp. We shouldn't omit adding the state to SPI hash because it'll not be possible to delete or lookup for it afterward: __xfrm_state_insert() obviously doesn't a