Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-19 Thread David Miller
From: Laura Abbott Date: Mon, 14 Mar 2016 13:07:06 -0700 > On 03/14/2016 12:24 PM, David Miller wrote: >> From: Claudio Imbrenda >> Date: Fri, 11 Mar 2016 13:39:23 +0100 >> >>> I think I found a problem with the patch submitted by Laura Abbott

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-14 Thread Laura Abbott
On 03/14/2016 12:24 PM, David Miller wrote: From: Claudio Imbrenda Date: Fri, 11 Mar 2016 13:39:23 +0100 I think I found a problem with the patch submitted by Laura Abbott ( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups. Since the condition is not

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-14 Thread David Miller
From: Claudio Imbrenda Date: Fri, 11 Mar 2016 13:39:23 +0100 > I think I found a problem with the patch submitted by Laura Abbott > ( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups. > Since the condition is not checked between the prepare_to_wait and the

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-11 Thread Claudio Imbrenda
Hello, I think I found a problem with the patch submitted by Laura Abbott ( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups. Since the condition is not checked between the prepare_to_wait and the schedule(), if a wakeup happens after the condition is checked but before the sleep

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-02-13 Thread David Miller
From: Laura Abbott Date: Thu, 4 Feb 2016 10:50:45 -0800 > We receoved a bug report from someone using vmware: ... > transport->stream_enqueue may call copy_to_user so it should > not be called inside a prepare_to_wait. Narrow the scope of > the prepare_to_wait to

[PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-02-04 Thread Laura Abbott
We receoved a bug report from someone using vmware: WARNING: CPU: 3 PID: 660 at kernel/sched/core.c:7389 __might_sleep+0x7d/0x90() do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x2d/0x90 Modules linked in: vmw_vsock_vmci_transport vsock snd_seq_midi