Re: [PATCHv2 iproute2] bridge/mdb: fix missing new line when show bridge mdb

2018-09-11 Thread Stephen Hemminger
On Tue, 11 Sep 2018 09:26:35 +0800 Hangbin Liu wrote: > + if (!is_json_context() && !show_stats) > + print_string(PRINT_FP, NULL, "\n", NULL); I just added print_nl to json_print which does what you want.

Re: [PATCHv2 iproute2] bridge/mdb: fix missing new line when show bridge mdb

2018-09-11 Thread Phil Sutter
Hi Hangbin, On Tue, Sep 11, 2018 at 09:26:35AM +0800, Hangbin Liu wrote: [...] > + if (!is_json_context() && !show_stats) > + print_string(PRINT_FP, NULL, "\n", NULL); There is no need to check for !is_json_context() here. You give a type of PRINT_FP which won't lead to output if

[PATCHv2 iproute2] bridge/mdb: fix missing new line when show bridge mdb

2018-09-10 Thread Hangbin Liu
The bridge mdb show is broken on current iproute2. e.g. ]# bridge mdb show 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp After fix: ]# bridge mdb show 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp v2: use json print lib as Stephen suggested.