Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-12 Thread William Tu
On Fri, Jan 12, 2018 at 10:39 AM, Pravin Shelar wrote: > On Fri, Jan 12, 2018 at 12:27 AM, Jiri Benc wrote: >> On Thu, 11 Jan 2018 08:34:14 -0800, William Tu wrote: >>> I'd also prefer reverting ceaa001a170e since it's more clean but I >>> also hope to have

Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-12 Thread Pravin Shelar
On Fri, Jan 12, 2018 at 12:27 AM, Jiri Benc wrote: > On Thu, 11 Jan 2018 08:34:14 -0800, William Tu wrote: >> I'd also prefer reverting ceaa001a170e since it's more clean but I >> also hope to have this feature in 4.15. >> How long does reverting take? Am I only able to submit

Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-12 Thread Jiri Benc
On Thu, 11 Jan 2018 08:34:14 -0800, William Tu wrote: > I'd also prefer reverting ceaa001a170e since it's more clean but I > also hope to have this feature in 4.15. > How long does reverting take? Am I only able to submit the new patch > after the reverting is merged? Or I can submit revert and

Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-11 Thread William Tu
Hi Jiri, Thanks a lot for the comments. On Wed, Jan 10, 2018 at 2:02 PM, Jiri Benc wrote: > On Wed, 10 Jan 2018 22:35:14 +0100, Jiri Benc wrote: >> The existing field must continue to work in the same way as before. It must >> be accepted and *returned* by the kernel. You may

Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-10 Thread Jiri Benc
On Wed, 10 Jan 2018 22:35:14 +0100, Jiri Benc wrote: > The existing field must continue to work in the same way as before. It must > be accepted and *returned* by the kernel. You may add an additional field > but the existing behavior must be 100% preserved, both uABI and uAPI wise. Another way

Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-10 Thread Jiri Benc
On Tue, 9 Jan 2018 17:51:22 -0800, William Tu wrote: > - [OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS] = { .len = sizeof(u32) }, > + [OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1] = { .len = sizeof(u32) }, > + [OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS] = { .len = OVS_ATTR_NESTED, > +

Re: [PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-10 Thread Jiri Benc
On Tue, 9 Jan 2018 17:51:22 -0800, William Tu wrote: > --- a/include/uapi/linux/openvswitch.h > +++ b/include/uapi/linux/openvswitch.h > @@ -363,7 +373,8 @@ enum ovs_tunnel_key_attr { > OVS_TUNNEL_KEY_ATTR_IPV6_SRC, /* struct in6_addr src IPv6 > address. */ >

[PATCHv2 net-next 2/2] openvswitch: add erspan version II support

2018-01-09 Thread William Tu
The patch adds support for configuring the erspan V2 fields for openvswitch. For compatibility reason, the previously added attribute 'OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS' is renamed to 'OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTSV1' and deprecated, and the newly added attribute 'OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS'