Re: [PATCHv2 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-24 Thread Joe Stringer
On 24 October 2015 at 01:20, Florian Westphal wrote: > Joe Stringer wrote: >> err: >> + if (err) >> + kfree_skb(skb); >> skb_push(skb, nh_ofs); > > That looks... wrong :-} D'oh. Teaches me for last minute adjustments. I'll resend. -- To unsubscribe from this list: send the

Re: [PATCHv2 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-24 Thread Florian Westphal
Joe Stringer wrote: > err: > + if (err) > + kfree_skb(skb); > skb_push(skb, nh_ofs); That looks... wrong :-} -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

[PATCHv2 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-23 Thread Joe Stringer
If ip_defrag() returns an error other than -EINPROGRESS, then the skb is freed. When handle_fragments() passes this back up to do_execute_actions(), it will be freed again. Prevent this double free by never freeing the skb in do_execute_actions() for errors returned by ovs_ct_execute. Always free i