Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-19 Thread Thomas Graf
On 10/19/15 at 04:13pm, Joe Stringer wrote: > I think that the proper solution instead of this patch is to set NEW > if !nf_ct_is_confirmed(ct). This is more accurately the meaning for > 'NEW' that we are actually trying to expose. As long as this is done > before confirming the connection during a

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-19 Thread Joe Stringer
On 19 October 2015 at 02:03, Thomas Graf wrote: > On 10/19/15 at 12:07am, Joe Stringer wrote: >> > I'm probably missing something obvious. Why is the reply direction >> > not considered NEW? Wouldn't this consider an ICMPv6 as related+new >> > depending on simply the direction? >> >> My thoughts w

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-19 Thread Thomas Graf
On 10/19/15 at 12:07am, Joe Stringer wrote: > > I'm probably missing something obvious. Why is the reply direction > > not considered NEW? Wouldn't this consider an ICMPv6 as related+new > > depending on simply the direction? > > My thoughts were along the lines "If something is a reply, that > im

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-19 Thread Joe Stringer
On 17 October 2015 at 00:52, Thomas Graf wrote: > On 10/16/15 at 11:08am, Joe Stringer wrote: >> New, related connections are marked as such as part of ovs_ct_lookup(), >> but they are not marked as "new" if the commit flag is used. Make this >> consistent by treating IP_CT_RELATED as new as well.

Re: [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-17 Thread Thomas Graf
On 10/16/15 at 11:08am, Joe Stringer wrote: > New, related connections are marked as such as part of ovs_ct_lookup(), > but they are not marked as "new" if the commit flag is used. Make this > consistent by treating IP_CT_RELATED as new as well. > > Reported-by: Jarno Rajahalme > Signed-off-by: J

[PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-16 Thread Joe Stringer
New, related connections are marked as such as part of ovs_ct_lookup(), but they are not marked as "new" if the commit flag is used. Make this consistent by treating IP_CT_RELATED as new as well. Reported-by: Jarno Rajahalme Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar --- v2: Acked. -