Re: [PATCHv3 net 5/5] nfp: don't trust netif_running() in debug code

2016-02-20 Thread Jakub Kicinski
On 2/20/16, David Miller wrote: > From: Jakub Kicinski > Date: Thu, 18 Feb 2016 20:38:13 + > >> Since change_mtu() can fail and leave us with netif_running() >> returning true even though all rings were freed - we should >> look at NFP_NET_CFG_CTRL_ENABLE flag to determine if device >> is rea

Re: [PATCHv3 net 5/5] nfp: don't trust netif_running() in debug code

2016-02-19 Thread David Miller
From: Jakub Kicinski Date: Thu, 18 Feb 2016 20:38:13 + > Since change_mtu() can fail and leave us with netif_running() > returning true even though all rings were freed - we should > look at NFP_NET_CFG_CTRL_ENABLE flag to determine if device > is really opened. > > Signed-off-by: Jakub Kici

[PATCHv3 net 5/5] nfp: don't trust netif_running() in debug code

2016-02-18 Thread Jakub Kicinski
Since change_mtu() can fail and leave us with netif_running() returning true even though all rings were freed - we should look at NFP_NET_CFG_CTRL_ENABLE flag to determine if device is really opened. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c | 4 ++--