Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-30 Thread tanhuazhong
On 2018/10/30 17:11, Sergei Shtylyov wrote: On 10/29/2018 4:54 PM, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-30 Thread Sergei Shtylyov
On 10/29/2018 4:54 PM, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by:

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread tanhuazhong
On 2018/10/30 9:31, Joe Perches wrote: On Tue, 2018-10-30 at 09:21 +0800, tanhuazhong wrote: On 2018/10/30 1:44, Joe Perches wrote: On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add()

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread Joe Perches
On Tue, 2018-10-30 at 09:21 +0800, tanhuazhong wrote: > > On 2018/10/30 1:44, Joe Perches wrote: > > On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: > > > When hns3_nic_init_vector_data() fails to map ring to vector, > > > it should cancel the netif_napi_add() that has been successfully >

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread tanhuazhong
On 2018/10/30 1:44, Joe Perches wrote: On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. [] diff --git

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread Joe Perches
On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: > When hns3_nic_init_vector_data() fails to map ring to vector, > it should cancel the netif_napi_add() that has been successfully > done and then exits. [] > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >

[Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

2018-10-29 Thread Huazhong Tan
When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Huazhong Tan ---