Re: [Patch net] net_sched: check noop_qdisc before qdisc_hash_add()

2017-04-06 Thread David Miller
From: Cong Wang Date: Tue, 4 Apr 2017 18:51:30 -0700 > Dmitry reported a crash when injecting faults in > attach_one_default_qdisc() and dev->qdisc is still > a noop_disc, the check before qdisc_hash_add() fails > to catch it because it tests NULL. We should test >

Re: [Patch net] net_sched: check noop_qdisc before qdisc_hash_add()

2017-04-06 Thread Jiri Kosina
On Tue, 4 Apr 2017, Cong Wang wrote: > Dmitry reported a crash when injecting faults in > attach_one_default_qdisc() and dev->qdisc is still > a noop_disc, the check before qdisc_hash_add() fails > to catch it because it tests NULL. We should test > against noop_qdisc since it is the default

[Patch net] net_sched: check noop_qdisc before qdisc_hash_add()

2017-04-04 Thread Cong Wang
Dmitry reported a crash when injecting faults in attach_one_default_qdisc() and dev->qdisc is still a noop_disc, the check before qdisc_hash_add() fails to catch it because it tests NULL. We should test against noop_qdisc since it is the default qdisc at this point. Fixes: 59cc1f61f09c ("net: