Re: [Patch net-next] net_sched: get rid of rcu_barrier() in tcf_block_put_ext()

2017-12-03 Thread Cong Wang
On Sat, Dec 2, 2017 at 1:21 AM, Jiri Pirko wrote: > Sat, Dec 02, 2017 at 01:18:04AM CET, xiyou.wangc...@gmail.com wrote: >>Both Eric and Paolo noticed the rcu_barrier() we use in >>tcf_block_put_ext() could be a performance bottleneck when >>we have lots of filters. > > The

Re: [Patch net-next] net_sched: get rid of rcu_barrier() in tcf_block_put_ext()

2017-12-02 Thread Jiri Pirko
Sat, Dec 02, 2017 at 01:18:04AM CET, xiyou.wangc...@gmail.com wrote: >Both Eric and Paolo noticed the rcu_barrier() we use in >tcf_block_put_ext() could be a performance bottleneck when >we have lots of filters. The problem is not a lots of filters, the problem is lots of classes and therefore

[Patch net-next] net_sched: get rid of rcu_barrier() in tcf_block_put_ext()

2017-12-01 Thread Cong Wang
Both Eric and Paolo noticed the rcu_barrier() we use in tcf_block_put_ext() could be a performance bottleneck when we have lots of filters. Paolo provided the following to demonstrate the issue: tc qdisc add dev lo root htb for I in `seq 1 1000`; do tc class add dev lo parent 1: classid