Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Sun, Aug 30, 2015 at 12:07 PM, Jamal Hadi Salim wrote: > On 08/28/15 19:20, David Miller wrote: > >> But HTB definitely should be allowed. > > > Problem with most non-work conserving schedulers is what the meaning > of default resources means; example, for HTB: > What is the

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang Date: Tue, 1 Sep 2015 23:05:45 -0700 > On Sun, Aug 30, 2015 at 12:07 PM, Jamal Hadi Salim wrote: >> On 08/28/15 19:20, David Miller wrote: >> >>> But HTB definitely should be allowed. >> >> >> Problem with most non-work conserving

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Tue, Sep 1, 2015 at 11:19 PM, David Miller wrote: > From: Cong Wang > Date: Tue, 1 Sep 2015 23:05:45 -0700 > >> On Sun, Aug 30, 2015 at 12:07 PM, Jamal Hadi Salim wrote: >>> On 08/28/15 19:20, David Miller wrote: >>> But

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On 08/28/15 19:20, David Miller wrote: But HTB definitely should be allowed. Problem with most non-work conserving schedulers is what the meaning of default resources means; example, for HTB: What is the default bandwidth you allocate to a class of users? cheers, jamal -- To unsubscribe

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On 08/28/15 00:23, David Miller wrote: If a default qdisc like HTB is choosen, we invoke the -init() function and we change the HTB -init() function to do something reasonable if a NULL set of configuration attributes is given. ie. make HTB use some defaults. That may work. Or to reduce

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang xiyou.wangc...@gmail.com Date: Fri, 28 Aug 2015 14:39:45 -0700 If HTB is not a good example, as using HTB as default might make some sense, please try ingress qdisc, no error at _any_ time, and apparently defaulting to ingress is totally non-sense. I agree that ingress should

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Thu, Aug 27, 2015 at 9:23 PM, David Miller da...@davemloft.net wrote: From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015 18:49:09 -0700 On Thu, Aug 27, 2015 at 4:18 PM, David Miller da...@davemloft.net wrote: From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Thu, Aug 27, 2015 at 3:42 PM, David Miller da...@davemloft.net wrote: Long term it's the wrong fix, trust me. So we have plan to convert some non-defaultable qdisc to defaultable? I don't see a reason here. If you fix it properly, by making every qdisc capable of being -init()'d without

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015 15:47:55 -0700 On Thu, Aug 27, 2015 at 3:42 PM, David Miller da...@davemloft.net wrote: If you fix it properly, by making every qdisc capable of being -init()'d without explicit parameters, it will be the best behavior overall.

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang xiyou.wangc...@gmail.com Date: Wed, 26 Aug 2015 15:41:26 -0700 Currently there is no check for if a qdisc is appropriate to be used as the default qdisc. This causes we get no error even we set the default qdisc to an inappropriate one but an error will be shown up later. This

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Thu, Aug 27, 2015 at 3:30 PM, David Miller da...@davemloft.net wrote: I don't like this. The situation is that some sophisticated qdiscs can function without explicit parameters, some cannot. This is exactly what this patch tries to solve... I already mark those with a DEFAULTABLE flag.

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015 15:39:12 -0700 On Thu, Aug 27, 2015 at 3:30 PM, David Miller da...@davemloft.net wrote: I don't like this. The situation is that some sophisticated qdiscs can function without explicit parameters, some cannot. This is exactly

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Thu, Aug 27, 2015 at 4:18 PM, David Miller da...@davemloft.net wrote: From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015 15:47:55 -0700 On Thu, Aug 27, 2015 at 3:42 PM, David Miller da...@davemloft.net wrote: If you fix it properly, by making every qdisc capable of being

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015 18:49:09 -0700 On Thu, Aug 27, 2015 at 4:18 PM, David Miller da...@davemloft.net wrote: From: Cong Wang xiyou.wangc...@gmail.com Date: Thu, 27 Aug 2015 15:47:55 -0700 On Thu, Aug 27, 2015 at 3:42 PM, David Miller

[Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

Currently there is no check for if a qdisc is appropriate to be used as the default qdisc. This causes we get no error even we set the default qdisc to an inappropriate one but an error will be shown up later. This is not good. Also, for qdisc's like HTB, kernel will just crash when we use it as

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Wed, Aug 26, 2015 at 5:08 PM, Stephen Hemminger step...@networkplumber.org wrote: On Wed, 26 Aug 2015 15:41:26 -0700 Cong Wang xiyou.wangc...@gmail.com wrote: Currently there is no check for if a qdisc is appropriate to be used as the default qdisc. This causes we get no error even we set

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

On Wed, 26 Aug 2015 15:41:26 -0700 Cong Wang xiyou.wangc...@gmail.com wrote: Currently there is no check for if a qdisc is appropriate to be used as the default qdisc. This causes we get no error even we set the default qdisc to an inappropriate one but an error will be shown up later. This