Re: [REGRESSION] tg3 dead after s2ram

2007-08-03 Thread Joachim Deguara
On Thursday 02 August 2007 21:10:29 Michael Chan wrote: Alternatively, we can also fix it by calling pci_enable_device() again in tg3_open().  But I think it is better to just always save and restore in suspend/resume.  bnx2.c will also require the same fix. Thanks Joachim for helping to

Re: [REGRESSION] tg3 dead after s2ram

2007-08-03 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 02 Aug 2007 12:10:29 -0700 [TG3]: Fix suspend/resume problem. Joachim Deguara [EMAIL PROTECTED] reported that tg3 devices would not resume properly if the device was shutdown before the system was suspended. In such scenario where the

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread Joachim Deguara
On Wednesday 01 August 2007 23:00:23 Michael Chan wrote: On Wed, 2007-08-01 at 10:47 -0700, Michael Chan wrote: You have 2 Broadcom devices in your system. 07:00.0 is a wireless device, I think. 8:4.0 is the tg3 device. It's clear that the tg3 device is still in D3 state after resume

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread Joachim Deguara
On Thursday 02 August 2007 10:05:44 Joachim Deguara wrote: On Wednesday 01 August 2007 23:00:23 Michael Chan wrote: On Wed, 2007-08-01 at 10:47 -0700, Michael Chan wrote: The problem is that memory enable and bus master were not set in PCI register 4 after resume. This also explains the

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread David Miller
From: Joachim Deguara [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 11:15:05 +0200 Seams like even if powersave shuts down the network that the device should still work after a suspend to ram, so who is at fault here? It's a good question. The pci_enable() is done on the PCI device at probe time,

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread Michael Chan
On Thu, 2007-08-02 at 02:23 -0700, David Miller wrote: From: Joachim Deguara [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 11:15:05 +0200 Seams like even if powersave shuts down the network that the device should still work after a suspend to ram, so who is at fault here? It's a good

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 02 Aug 2007 12:10:29 -0700 On Thu, 2007-08-02 at 02:23 -0700, David Miller wrote: From: Joachim Deguara [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 11:15:05 +0200 Seams like even if powersave shuts down the network that the device should

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread Michael Chan
On Thu, 2007-08-02 at 15:06 -0700, David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Thu, 02 Aug 2007 12:10:29 -0700 Alternatively, we can also fix it by calling pci_enable_device() again in tg3_open(). But I think it is better to just always save and restore in

Re: [REGRESSION] tg3 dead after s2ram

2007-08-01 Thread Michael Chan
On Tue, 2007-07-31 at 17:45 -0700, Andrew Morton wrote: On Tue, 31 Jul 2007 11:28:32 +0200 Joachim Deguara [EMAIL PROTECTED] wrote: On my Acer Ferrari 1000 the tg3 ethernet no longer is available after a suspend to ram with the latet 2.6.23-rc1-git9. It seems to work for me on the same

Re: [REGRESSION] tg3 dead after s2ram

2007-08-01 Thread Michael Chan
On Wed, 2007-08-01 at 10:01 +0200, Joachim Deguara wrote: Here are the lspci outputs for the tg3 You have 2 Broadcom devices in your system. 07:00.0 is a wireless device, I think. 8:4.0 is the tg3 device. It's clear that the tg3 device is still in D3 state after resume and that explains why

Re: [REGRESSION] tg3 dead after s2ram

2007-08-01 Thread Michael Chan
On Wed, 2007-08-01 at 10:47 -0700, Michael Chan wrote: You have 2 Broadcom devices in your system. 07:00.0 is a wireless device, I think. 8:4.0 is the tg3 device. It's clear that the tg3 device is still in D3 state after resume and that explains why all register accesses fail.

Re: [REGRESSION] tg3 dead after s2ram

2007-07-31 Thread Andrew Morton
On Tue, 31 Jul 2007 11:28:32 +0200 Joachim Deguara [EMAIL PROTECTED] wrote: On my Acer Ferrari 1000 the tg3 ethernet no longer is available after a suspend to ram with the latet 2.6.23-rc1-git9. Thanks. cc's added, body retained.. The tg3 works fine with s2ram in 2.6.22.1. The tell