Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-14 Thread Urs Thuermann
David Miller [EMAIL PROTECTED] writes: Can tcpdump and libpcap already handle PPP properly? Yes, with the (admittedly non-serious) limitation, that both, tcpdump and tcpdump -e don't show the PPP header. I don't remember how tcpdump behaved on BSD in this respect (so many years ago), but I

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-13 Thread Urs Thuermann
Hello Dave, But if libpcap and tcpdump can already identify PPP packets then, besides consistency, what does this buy us other than potential breakage? My reason for the patch is mostly cleanliness and to make the kernel match what is described in packet(7). If you open a PF_PACKET/SOCK_RAW

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-13 Thread David Miller
From: Urs Thuermann [EMAIL PROTECTED] Date: 13 Feb 2008 17:56:00 +0100 Do you consider this strong enough to justify this change? Can tcpdump and libpcap already handle PPP properly? -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-12 Thread David Miller
From: Urs Thuermann [EMAIL PROTECTED] Date: 10 Feb 2008 10:48:51 +0100 So what is your opinion about this change? No general objections from me. But if libpcap and tcpdump can already identify PPP packets then, besides consistency, what does this buy us other than potential breakage? -- To

[RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-10 Thread Urs Thuermann
The PPP interface strips off the PPP header from the packet before passing it up with netif_rx(). On the xmit path, it has to add the PPP header itself because dev-header_ops is NULL. This means that a PF_PACKET, SOCK_RAW socket can't get the link level header and has to use the sll_protocol