Re: [RFC] Arp announce (for Xen)

2007-03-06 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: + case NETDEV_CHANGEADDR: + /* Send gratuitous ARP in case of address change or new device */ + if (IN_DEV_ARP_ANNOUNCE(in_dev)) Conceptually right on, but it looks like improper hijacking of arp_announce sysctl.

Re: [RFC] Arp announce (for Xen)

2007-03-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 1 Mar 2007 17:30:30 -0800 What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented.

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread Pekka Savola
On Thu, 1 Mar 2007, Stephen Hemminger wrote: What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented. If something like this goes in, it

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread Ben Greear
Pekka Savola wrote: On Thu, 1 Mar 2007, Stephen Hemminger wrote: What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented.

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread Stephen Hemminger
On Fri, 02 Mar 2007 10:29:53 -0800 Ben Greear [EMAIL PROTECTED] wrote: Pekka Savola wrote: On Thu, 1 Mar 2007, Stephen Hemminger wrote: What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread Keir Fraser
On 2/3/07 01:30, Stephen Hemminger [EMAIL PROTECTED] wrote: What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented. This would be

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread Andi Kleen
On Thu, Mar 01, 2007 at 05:30:30PM -0800, Stephen Hemminger wrote: What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented. Seems like the

Re: [RFC] Arp announce (for Xen)

2007-03-02 Thread jamal
On Fri, 2007-02-03 at 13:54 +0100, Andi Kleen wrote: Seems like the right solution to me (if it works) I like it as well given the simple change. These are the kind of optimizations that justify offloading things to the kernel (instead of user space) i.e very little lines of code, covers a

[RFC] Arp announce (for Xen)

2007-03-01 Thread Stephen Hemminger
What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented. diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index e10794d..cefc339 100644 ---