Re: [RFC] allow device to stop packet mirror behaviour

2007-08-08 Thread Johannes Berg
On Tue, 2007-08-07 at 18:06 -0700, David Miller wrote: From: Johannes Berg [EMAIL PROTECTED] Date: Tue, 07 Aug 2007 10:25:55 +0200 The only way to solve this problem therefore seems to be to suppress the mirroring out of the packet by dev_queue_xmit_nit(). The patch below does that by

Re: [RFC] allow device to stop packet mirror behaviour

2007-08-08 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Wed, 08 Aug 2007 11:14:01 +0200 On Tue, 2007-08-07 at 18:06 -0700, David Miller wrote: From: Johannes Berg [EMAIL PROTECTED] Date: Tue, 07 Aug 2007 10:25:55 +0200 The only way to solve this problem therefore seems to be to suppress the

Re: [RFC] allow device to stop packet mirror behaviour

2007-08-08 Thread Johannes Berg
On Wed, 2007-08-08 at 03:17 -0700, David Miller wrote: Then I don't understand your problem. If they are specific 802.11 protocol packets, the radio stack is in a much better situation to filter out things like this. What do you mean by radio stack? You can't really send any frames into the

[RFC] allow device to stop packet mirror behaviour

2007-08-07 Thread Johannes Berg
In the wireless code, we have special 802.11+radiotap framed virtual interfaces, mostly used to monitor traffic on the air. They also show outgoing packets from other virtual interfaces associated with the same PHY because you can't receive packets while sending. Due to the design of the virtual

Re: [RFC] allow device to stop packet mirror behaviour

2007-08-07 Thread Johannes Berg
This is the corresponding patch to mac80211. It marks all monitor type interfaces with IFF_NO_MIRROR the reasons for which I explained in the previous mail; it also marks the master device with IFF_NO_MIRROR so you don't see *any* packets on the master device (right now you see outgoing frames

Re: [RFC] allow device to stop packet mirror behaviour

2007-08-07 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Tue, 07 Aug 2007 10:25:55 +0200 The only way to solve this problem therefore seems to be to suppress the mirroring out of the packet by dev_queue_xmit_nit(). The patch below does that by way of adding a new netdev flag. Multicast packets also get