Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Roopa Prabhu
On Fri, Oct 13, 2017 at 12:11 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:53:56PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli >>wrote: >>> On 10/12/2017 12:06 PM, David Miller wrote: From: Florian Fainelli Date: Thu, 12 Oct 2017 08:4

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Jiri Pirko
Thu, Oct 12, 2017 at 11:53:56PM CEST, ro...@cumulusnetworks.com wrote: >On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli >wrote: >> On 10/12/2017 12:06 PM, David Miller wrote: >>> From: Florian Fainelli >>> Date: Thu, 12 Oct 2017 08:43:59 -0700 >>> Once we move ethtool (or however we name

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Jiri Pirko
Thu, Oct 12, 2017 at 10:12:31PM CEST, steven.l...@broadcom.com wrote: >On Thu, Oct 12, 2017 at 3:20 PM, Florian Fainelli wrote: >> On 10/12/2017 12:06 PM, David Miller wrote: >>> From: Florian Fainelli >>> Date: Thu, 12 Oct 2017 08:43:59 -0700 >>> Once we move ethtool (or however we name its

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Thu, 12 Oct 2017 08:43:59 -0700 >> >>> Once we move ethtool (or however we name its successor) over to >>> netlink there is an opportunity for accessing objec

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Michal Kubecek
On Thu, Oct 12, 2017 at 12:20:07PM -0700, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: > > > > One suggestion is that devlink is used for getting ethtool stats for > > objects lacking netdev representor's, and a new genetlink family is > > used for netdev based ethtool. >

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Steve Lin
On Thu, Oct 12, 2017 at 3:20 PM, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Thu, 12 Oct 2017 08:43:59 -0700 >> >>> Once we move ethtool (or however we name its successor) over to >>> netlink there is an opportunity for accessing object

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Florian Fainelli
On 10/12/2017 12:06 PM, David Miller wrote: > From: Florian Fainelli > Date: Thu, 12 Oct 2017 08:43:59 -0700 > >> Once we move ethtool (or however we name its successor) over to >> netlink there is an opportunity for accessing objects that do and do >> not have a netdevice representor today (e.g:

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread David Miller
From: Florian Fainelli Date: Thu, 12 Oct 2017 08:43:59 -0700 > Once we move ethtool (or however we name its successor) over to > netlink there is an opportunity for accessing objects that do and do > not have a netdevice representor today (e.g: management ports on > switches) with the same interf

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread David Miller
From: Jiri Pirko Date: Thu, 12 Oct 2017 17:04:19 +0200 > Not sure we want to go this way and add "netdev"-handle things into > devlink. Thoughts? I think we should avoid this and keep devlink to it's designed purpose.

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread David Miller
From: Roopa Prabhu Date: Thu, 12 Oct 2017 07:46:24 -0700 > FWIS, devlink is a driver api just like ethtool is. Devlink a driver API for doing operations where we don't have a specific 'netdev' object to work upon. > and ethtool needs to move to netlink soon...and It would be better to > not put

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread David Miller
From: Jiri Pirko Date: Thu, 12 Oct 2017 16:40:32 +0200 > Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >>> Adds a devlink command for getting & setting device configuration >>> parameters, and enumerates a bunch of thos

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:43 AM, Florian Fainelli wrote: > On October 12, 2017 8:04:19 AM PDT, Jiri Pirko wrote: >>Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulus

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Florian Fainelli
On October 12, 2017 8:04:19 AM PDT, Jiri Pirko wrote: >Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: >>> Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com >wrote: On Thu, Oct 12, 2017 at 6:34 AM, Steve

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:04 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: >>> Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: On Thu, Oct 12, 2017 at 6:34 AM, Steve Li

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Jiri Pirko
Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: >> Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >>>On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: Adds a devlink command for getting & setti

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:45 AM, Steve Lin wrote: > Hi Roopa, > > The attributes added in this patchset are not really the same type as > ethtool - these are more device configuration type attributes. The > speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] > configuration for a

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >>> Adds a devlink command for getting & setting device configuration >>> parameters, and enumerates a bunch of those par

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Steve Lin
Hi Roopa, The attributes added in this patchset are not really the same type as ethtool - these are more device configuration type attributes. The speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] configuration for a port, and aren't run-time speed changes on a given netdev like

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Jiri Pirko
Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >> Adds a devlink command for getting & setting device configuration >> parameters, and enumerates a bunch of those parameters as devlink >> attributes. Also introduces an att

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: > Adds a devlink command for getting & setting device configuration > parameters, and enumerates a bunch of those parameters as devlink > attributes. Also introduces an attribute that can be set by a > driver to indicate that the config change doe

[RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Steve Lin
Adds a devlink command for getting & setting device configuration parameters, and enumerates a bunch of those parameters as devlink attributes. Also introduces an attribute that can be set by a driver to indicate that the config change doesn't take effect until the next restart (as in the case of