On Tue, Sep 20, 2016 at 03:04:12PM +, Elior, Ariel wrote:
> > From: Leon Romanovsky [mailto:l...@kernel.org]
> > On Thu, Sep 15, 2016 at 05:11:03AM +, Mintz, Yuval wrote:
> > > > As a summary, I didn't see in your responses any real life example
> > > > where you will
> > > > need global d
> From: Leon Romanovsky [mailto:l...@kernel.org]
> On Thu, Sep 15, 2016 at 05:11:03AM +, Mintz, Yuval wrote:
> > > As a summary, I didn't see in your responses any real life example where
> > > you will
> > > need global debug level for your driver.
> >
> > Not sure what you you're expecting -
On Thu, Sep 15, 2016 at 05:11:03AM +, Mintz, Yuval wrote:
> > As a summary, I didn't see in your responses any real life example where
> > you will
> > need global debug level for your driver.
>
> Not sure what you you're expecting - a list of BZs /private e-mails where
> user reproductions we
> > > If you want dynamic prints, you have two options:
> > > 1. Add support of ethtool to whole RDMA stack.
> > > 2. Use dynamic tracing infrastructure.
> >
> > > Which option do you prefer?
> > Option 3 - continuing this discussion. :-)
>
> Sorry,
> I was under impression that you want this driv
On Wed, Sep 14, 2016 at 06:25:38PM +, Mintz, Yuval wrote:
> > > > > >> >> +uint debug;
> > > > > >> >> +module_param(debug, uint, 0);
> > > > > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
> > > > > >>
> > > > > >> >Why are you adding this as a module parameter?
> > > > > >>
> > >
> > > > >> >> +uint debug;
> > > > >> >> +module_param(debug, uint, 0);
> > > > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
> > > > >>
> > > > >> >Why are you adding this as a module parameter?
> > > > >>
> > > > >> I believe this is mostly to follow same line as qede which also
> >
On Wed, Sep 14, 2016 at 08:15:23AM +, Mintz, Yuval wrote:
> > > >> >> +uint debug;
> > > >> >> +module_param(debug, uint, 0);
> > > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
> > > >>
> > > >> >Why are you adding this as a module parameter?
> > > >>
> > > >> I believe this is mo
> > >> >> +uint debug;
> > >> >> +module_param(debug, uint, 0);
> > > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
> > >>
> > >> >Why are you adding this as a module parameter?
> > >>
> > >> I believe this is mostly to follow same line as qede which also defines
> > > > 'debug' module p
> > + if ((event != NETDEV_CHANGENAME) && (event !=
> > NETDEV_CHANGEADDR))
>
> nit: You don't really need the extra parens here.
>
Sure, thanks. Will remove.
> Adds a skeletal implementation of the qed* RoCE driver -
> basically the ability to communicate with the qede driver and
> receive notifications from it regarding various init/exit events.
>
> Signed-off-by: Rajesh Borundia
> Signed-off-by: Ram Amrani
> ---
> drivers/infiniband/Kconfig
On Tue, Sep 13, 2016 at 09:22:04AM +, Ram Amrani wrote:
> Thanks for your comments.
> See my replies in line with [Ram].
Please configure your email client
https://www.kernel.org/doc/Documentation/email-clients.txt
Thanks
signature.asc
Description: PGP signature
On Tue, Sep 13, 2016 at 07:18:01AM +, Mintz, Yuval wrote:
> >> >> +uint debug;
> >> >> +module_param(debug, uint, 0);
> > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
> >>
> >> >Why are you adding this as a module parameter?
> >>
> >> I believe this is mostly to follow same line as
; linux-r...@vger.kernel.org; netdev
Subject: Re: [RFC 02/11] Add RoCE driver framework
Hi Ram,
Just a few thoughts
On 12/09/2016 19:07, Ram Amrani wrote:
> Adds a skeletal implementation of the qed* RoCE driver - basically the
> ability to communicate with the qede driver and r
>> >> +uint debug;
>> >> +module_param(debug, uint, 0);
> >>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
>>
>> >Why are you adding this as a module parameter?
>>
>> I believe this is mostly to follow same line as qede which also defines
> > 'debug' module parameter for allowing easy user
On Mon, Sep 12, 2016 at 07:07:36PM +0300, Ram Amrani wrote:
> Adds a skeletal implementation of the qed* RoCE driver -
> basically the ability to communicate with the qede driver and
> receive notifications from it regarding various init/exit events.
>
> Signed-off-by: Rajesh Borundia
> Signed-off
On Mon, Sep 12, 2016 at 07:17:35PM +, Yuval Mintz wrote:
> >> +uint debug;
> >> +module_param(debug, uint, 0);
> >> +MODULE_PARM_DESC(debug, "Default debug msglevel");
>
> >Why are you adding this as a module parameter?
>
> I believe this is mostly to follow same line as qede which also defines
Hi Ram,
Just a few thoughts
On 12/09/2016 19:07, Ram Amrani wrote:
> Adds a skeletal implementation of the qed* RoCE driver -
> basically the ability to communicate with the qede driver and
> receive notifications from it regarding various init/exit events.
>
> Signed-off-by: Rajesh Borundia
>> +uint debug;
>> +module_param(debug, uint, 0);
>> +MODULE_PARM_DESC(debug, "Default debug msglevel");
>Why are you adding this as a module parameter?
I believe this is mostly to follow same line as qede which also defines
'debug' module parameter for allowing easy user control of debug
prints
Adds a skeletal implementation of the qed* RoCE driver -
basically the ability to communicate with the qede driver and
receive notifications from it regarding various init/exit events.
Signed-off-by: Rajesh Borundia
Signed-off-by: Ram Amrani
---
drivers/infiniband/Kconfig |
19 matches
Mail list logo
