Re: [RFC 3/3] networking: make skb_push & __skb_push return void pointers

On Fri, 2017-06-16 at 02:19 -0700, Joe Perches wrote: > > >   if (frag_size  == > > PN533_CMD_DATAFRAME_MAXLEN) > > - *skb_push(frag, sizeof(u8)) = > > - (PN533_CMD > > _MI_MASK | 1); > > -

Re: [RFC 3/3] networking: make skb_push & __skb_push return void pointers

On Fri, 2017-06-16 at 00:12 +0200, Johannes Berg wrote: > From: Johannes Berg [] > diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c [] > @@ -2090,10 +2090,10 @@ static int pn533_fill_fragment_skbs(struct pn533 > *dev, struct sk_buff *skb) > >

[RFC 3/3] networking: make skb_push & __skb_push return void pointers

From: Johannes Berg It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions return void * and remove all the casts across the tree, adding a (u8 *) cast only where