Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-23 Thread Thomas Graf
On 04/22/15 at 04:38pm, Cong Wang wrote: On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 4/21/15 10:05 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: introduce tc_classify_act() and qdisc_drop_bypass()

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 4/21/15 10:05 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 10:05 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among different qdiscs I don't think qdisc_drop_bypass() is more readable than without

[RFC 3/3] tc: cleanup tc_classify

2015-04-21 Thread Alexei Starovoitov
introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among different qdiscs Signed-off-by: Alexei Starovoitov a...@plumgrid.com --- include/net/pkt_sched.h |2 ++ include/net/sch_generic.h |7 +++ net/sched/sch_api.c | 20

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-21 Thread Cong Wang
On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov a...@plumgrid.com wrote: introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among different qdiscs I don't think qdisc_drop_bypass() is more readable than without it, maybe you need a better name, or