Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Rob Herring
On Wed, Aug 23, 2017 at 8:57 AM, Russell King - ARM Linux wrote: > On Mon, Aug 21, 2017 at 02:12:42PM -0500, Rob Herring wrote: >> On Mon, Aug 21, 2017 at 10:06 AM, Baruch Siach wrote: >> > Hi Russell, >> > >> > On Mon, Aug 21, 2017 at 01:53:17PM +0100, Russell King - ARM Linux wrote: >> >> On Su

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Russell King - ARM Linux
On Mon, Aug 21, 2017 at 06:06:53PM +0300, Baruch Siach wrote: > Hi Russell, > > On Mon, Aug 21, 2017 at 01:53:17PM +0100, Russell King - ARM Linux wrote: > > Note that I didn't expect the SFP code to just get merged with very > > little in the way of real in-depth review of things like: > > > > *

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Russell King - ARM Linux
On Mon, Aug 21, 2017 at 02:12:42PM -0500, Rob Herring wrote: > On Mon, Aug 21, 2017 at 10:06 AM, Baruch Siach wrote: > > Hi Russell, > > > > On Mon, Aug 21, 2017 at 01:53:17PM +0100, Russell King - ARM Linux wrote: > >> On Sun, Aug 20, 2017 at 01:28:06PM +0300, Baruch Siach wrote: > >> > Add devic

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Russell King - ARM Linux
On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > > > Signed-off-by: Baruch Siach

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Andrew Lunn
On Wed, Aug 23, 2017 at 03:16:53PM +0300, Baruch Siach wrote: > Hi Rob, > > On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > > Add device-tree binding documentation SFP transceivers. Support for SFP > > > transceivers has be

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-23 Thread Baruch Siach
Hi Rob, On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > > > Signed-off-by: Bar

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-22 Thread Rob Herring
On Tue, Aug 22, 2017 at 07:49:01AM +0300, Baruch Siach wrote: > Hi Rob, > > On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > > Add device-tree binding documentation SFP transceivers. Support for SFP > > > transceivers has be

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Baruch Siach
Hi Rob, On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > > > Signed-off-by: Bar

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Rob Herring
On Mon, Aug 21, 2017 at 10:06 AM, Baruch Siach wrote: > Hi Russell, > > On Mon, Aug 21, 2017 at 01:53:17PM +0100, Russell King - ARM Linux wrote: >> On Sun, Aug 20, 2017 at 01:28:06PM +0300, Baruch Siach wrote: >> > Add device-tree binding documentation SFP transceivers. Support for SFP >> > trans

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Rob Herring
On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > Add device-tree binding documentation SFP transceivers. Support for SFP > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > Signed-off-by: Baruch Siach > --- > > The SFP driver is on net-next. > > Not sure about the rate-

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Baruch Siach
Hi Russell, On Mon, Aug 21, 2017 at 01:53:17PM +0100, Russell King - ARM Linux wrote: > On Sun, Aug 20, 2017 at 01:28:06PM +0300, Baruch Siach wrote: > > Add device-tree binding documentation SFP transceivers. Support for SFP > > transceivers has been recently introduced (drivers/net/phy/sfp.c). >

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Andrew Lunn
> The implementation that I've designed is based around the boards that > I have access to and the various public SFP documentation. I think > documenting the bindings suggests that they are stable - I don't think > we're really ready to make that assertion yet - there may be things > that have be

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-21 Thread Russell King - ARM Linux
On Sun, Aug 20, 2017 at 01:28:06PM +0300, Baruch Siach wrote: > Add device-tree binding documentation SFP transceivers. Support for SFP > transceivers has been recently introduced (drivers/net/phy/sfp.c). > > Signed-off-by: Baruch Siach > --- > > The SFP driver is on net-next. > > Not sure abou

[RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-20 Thread Baruch Siach
Add device-tree binding documentation SFP transceivers. Support for SFP transceivers has been recently introduced (drivers/net/phy/sfp.c). Signed-off-by: Baruch Siach --- The SFP driver is on net-next. Not sure about the rate-select-gpio property name. The SFP+ standard (not supported yet) uses