Re: [RFC PATCH] net: realtek: r8169: implement set_link_ksettings()

2017-10-21 Thread Tobias Jakobi
Any comment on this one? I have been using this in my tree since submission. No issues to far. I guess I could also put a Fixes-tag? - Tobias Tobias Jakobi wrote: > Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially > implemented the new ethtool API, by replacing get_settings() > with ge

[RFC PATCH] net: realtek: r8169: implement set_link_ksettings()

2017-10-13 Thread Tobias Jakobi
Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially implemented the new ethtool API, by replacing get_settings() with get_link_ksettings(). This breaks ethtool, since the userspace tool (according to the new API specs) never tries the legacy set() call, when the new get() call succeeds. All