Re: [RFC PATCH] reuseport: compute the ehash only if needed

2017-12-14 Thread David Miller
From: Paolo Abeni Date: Thu, 14 Dec 2017 09:29:46 +0100 > I was unable to measure any performance regression for the hash based > demultiplexing, and I think that the number of function calls is > unchanged in such scenario (with vanilla kernel we have ehash() and > reuseport_select_sock(), with

Re: [RFC PATCH] reuseport: compute the ehash only if needed

2017-12-14 Thread Paolo Abeni
Hi, On Wed, 2017-12-13 at 15:08 -0500, David Miller wrote: > From: Paolo Abeni > Date: Tue, 12 Dec 2017 14:09:28 +0100 > > > When a reuseport socket group is using a BPF filter to distribute > > the packets among the sockets, we don't need to compute any hash > > value, but the current reuseport

Re: [RFC PATCH] reuseport: compute the ehash only if needed

2017-12-13 Thread David Miller
From: Paolo Abeni Date: Tue, 12 Dec 2017 14:09:28 +0100 > When a reuseport socket group is using a BPF filter to distribute > the packets among the sockets, we don't need to compute any hash > value, but the current reuseport_select_sock() requires the > caller to compute such hash in advance. >

Re: [RFC PATCH] reuseport: compute the ehash only if needed

2017-12-12 Thread Paolo Abeni
Hi, On Tue, 2017-12-12 at 12:44 -0500, Craig Gallek wrote: > On Tue, Dec 12, 2017 at 8:09 AM, Paolo Abeni wrote: > > When a reuseport socket group is using a BPF filter to distribute > > the packets among the sockets, we don't need to compute any hash > > value, but the current reuseport_select_so

Re: [RFC PATCH] reuseport: compute the ehash only if needed

2017-12-12 Thread Craig Gallek
On Tue, Dec 12, 2017 at 8:09 AM, Paolo Abeni wrote: > When a reuseport socket group is using a BPF filter to distribute > the packets among the sockets, we don't need to compute any hash > value, but the current reuseport_select_sock() requires the > caller to compute such hash in advance. > > Thi

[RFC PATCH] reuseport: compute the ehash only if needed

2017-12-12 Thread Paolo Abeni
When a reuseport socket group is using a BPF filter to distribute the packets among the sockets, we don't need to compute any hash value, but the current reuseport_select_sock() requires the caller to compute such hash in advance. This patch reworks reuseport_select_sock() to compute the hash valu