Re: [RFC PATCH 2/2] ixgbe: add af_packet direct copy support

2017-01-31 Thread John Fastabend
On 17-01-30 06:53 PM, Alexei Starovoitov wrote: > On 1/27/17 1:34 PM, John Fastabend wrote: >> +h2 = page_address(rx_buffer->page) + rx_buffer->page_offset - hdrlen; >> +eth = page_address(rx_buffer->page) + rx_buffer->page_offset, > > I don't think it compiles ;) Well that is what I get

Re: [RFC PATCH 2/2] ixgbe: add af_packet direct copy support

2017-01-30 Thread Alexei Starovoitov
On 1/27/17 1:34 PM, John Fastabend wrote: + h2 = page_address(rx_buffer->page) + rx_buffer->page_offset - hdrlen; + eth = page_address(rx_buffer->page) + rx_buffer->page_offset, I don't think it compiles ;) + /* This indicates a bug in ixgbe leaving for testing purposes */

[RFC PATCH 2/2] ixgbe: add af_packet direct copy support

2017-01-27 Thread John Fastabend
This implements the ndo ops for direct dma socket option. This is to start looking at the interface and driver work needed to enable it. Note error paths are not handled and I'm aware of a few bugs. For example interface must be up before attaching socket or else it will fail silently. TBD fix