Re: [RFC PATCH 2/4] net: enable UDP gro on demand.

2018-09-17 Thread Willem de Bruijn
On Mon, Sep 17, 2018 at 6:18 AM Paolo Abeni wrote: > > On Sun, 2018-09-16 at 14:23 -0400, Willem de Bruijn wrote: > > That udp gro implementation is clearly less complete than yours in > > this patchset. The point I wanted to bring up for discussion is not the > > protocol implementation, but the

Re: [RFC PATCH 2/4] net: enable UDP gro on demand.

2018-09-17 Thread Paolo Abeni
On Sun, 2018-09-16 at 14:23 -0400, Willem de Bruijn wrote: > That udp gro implementation is clearly less complete than yours in > this patchset. The point I wanted to bring up for discussion is not the > protocol implementation, but the infrastructure for enabling it > conditionally. I'm still

Re: [RFC PATCH 2/4] net: enable UDP gro on demand.

2018-09-16 Thread Willem de Bruijn
On Fri, Sep 14, 2018 at 1:16 PM Willem de Bruijn wrote: > > On Fri, Sep 14, 2018 at 11:47 AM Paolo Abeni wrote: > > > > Currently, the UDP GRO callback is always invoked, regardless of > > the existence of any actual user (e.g. a UDP tunnel). With retpoline > > enabled, this causes measurable

Re: [RFC PATCH 2/4] net: enable UDP gro on demand.

2018-09-14 Thread Willem de Bruijn
On Fri, Sep 14, 2018 at 11:47 AM Paolo Abeni wrote: > > Currently, the UDP GRO callback is always invoked, regardless of > the existence of any actual user (e.g. a UDP tunnel). With retpoline > enabled, this causes measurable overhead. > > This changeset introduces explicit accounting of the

[RFC PATCH 2/4] net: enable UDP gro on demand.

2018-09-14 Thread Paolo Abeni
Currently, the UDP GRO callback is always invoked, regardless of the existence of any actual user (e.g. a UDP tunnel). With retpoline enabled, this causes measurable overhead. This changeset introduces explicit accounting of the sockets requiring UDP GRO and updates the UDP offloads at runtime