Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 9:47 AM, David Miller da...@davemloft.net wrote: From: Lawrence Brakmo bra...@fb.com Date: Thu, 2 Jul 2015 18:21:24 -0700 This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 1:30 PM, Neal Cardwell ncardw...@google.com wrote: diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 48c3696..05e0da5 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -254,6 +254,10 @@ struct tcp_sock { u32 lost_out; /* Lost packets

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-06 Thread Lawrence Brakmo
On 7/3/15, 10:10 AM, Tom Herbert t...@herbertland.com wrote: On Thu, Jul 2, 2015 at 6:21 PM, Lawrence Brakmo bra...@fb.com wrote: This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread Tom Herbert
On Thu, Jul 2, 2015 at 6:21 PM, Lawrence Brakmo bra...@fb.com wrote: This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread Eric Dumazet
On Fri, 2015-07-03 at 09:37 -0700, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 03 Jul 2015 07:00:23 +0200 tcp_skb_cb is currently 44 bytes, so even if you add one u32, it should not exceed cb[] Please see sock_skb_cb, which consumes space in skb-cb[] in

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 03 Jul 2015 07:00:23 +0200 tcp_skb_cb is currently 44 bytes, so even if you add one u32, it should not exceed cb[] Please see sock_skb_cb, which consumes space in skb-cb[] in parallel with things like tcp_skb_cb. The usage of skb-cb[]

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread David Miller
From: Lawrence Brakmo bra...@fb.com Date: Thu, 2 Jul 2015 18:21:24 -0700 This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-03 Thread Neal Cardwell
diff --git a/include/linux/tcp.h b/include/linux/tcp.h index 48c3696..05e0da5 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -254,6 +254,10 @@ struct tcp_sock { u32 lost_out; /* Lost packets */ u32 sacked_out; /* SACK'd

[RFC PATCH net-next] tcp: add NV congestion control

2015-07-02 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 18:21 -0700, Lawrence Brakmo wrote: This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been